Jshint improvements #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`~~` operation is subtly different than `Math.floor`, it just removes anything right of the decimal. This results in a difference for negative numbers. Also, `~~` is much faster than `Math.floor`.
As a highly performance oriented library, we definitely need to use bitwise operations. - Removed no longer supported jshint properties - Remove several options that we're not using and are default to false - Also add separate .jshintrc for test folder that extends the root
| "curly" : true, // Require {} for every new block or scope. | ||
| "eqeqeq" : true, // Require triple equals i.e. `===`. | ||
| "es3" : false, // Adhere to ECMAScript 3 specification for legacy browsers like Internet Explorer 6/7/8. | ||
| "forin" : true, // Tolerate `for in` loops without `hasOwnPrototype`. |
There was a problem hiding this comment.
I think that should be false and forEach should be used instead
There was a problem hiding this comment.
The meaning of this is not which loop to use, but rather to enforce checking inside a for..in loop which is meant to make you check hasOwnProperty on keys of an object.
Also, forEach is actually not as fast as a regular for loop http://jsperf.com/for-vs-foreach/313.
BenjaminVanRyseghem
added a commit
that referenced
this pull request
Apr 25, 2015
Jshint improvements
|
👍 |
|
In numbro 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work started by @baer in adamwdraper/Numeral-js#100. I adjusted the original proposal to be a little less strict because we need things like bitwise operators.
What's here now seems like a good starting point so I'm opening this PR for a place of discussion for how strict jshint rules should be.